jose-torres commented on a change in pull request #23747: [SPARK-26848][SQL]
Introduce new option to Kafka source: offset by timestamp (starting/ending)
URL: https://github.com/apache/spark/pull/23747#discussion_r265610675
##########
File path:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaOffsetReader.scala
##########
@@ -179,6 +179,56 @@ private[kafka010] class KafkaOffsetReader(
KafkaSourceOffset(fetched)
}
+ def fetchSpecificTimestampBasedOffsets(topicTimestamps: Map[String, Long]):
KafkaSourceOffset = {
Review comment:
Is there a way to share more code with fetchSpecificOffsets() here? I know a
lot of the implementation is a bit different, but I don't like the idea of
having complicated things like "workaround for KAFKA-7703" in multiple
independent places.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
