sujith71955 commented on a change in pull request #24075: [SPARK-26176][SQL] 
Invalid column names validation is been added when we create a table using the 
Hive serde "STORED AS"
URL: https://github.com/apache/spark/pull/24075#discussion_r265638340
 
 

 ##########
 File path: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveStrategies.scala
 ##########
 @@ -155,7 +155,7 @@ object HiveAnalysis extends Rule[LogicalPlan] {
       CreateTableCommand(tableDesc, ignoreIfExists = mode == SaveMode.Ignore)
 
     case CreateTable(tableDesc, mode, Some(query)) if 
DDLUtils.isHiveTable(tableDesc) =>
-      DDLUtils.checkDataColNames(tableDesc)
+      DDLUtils.checkDataColNames(tableDesc.copy(schema = query.schema))
 
 Review comment:
   And moreover one more problem what i observed is in serde class name defined 
"parquet.hive.serde.ParquetHiveSerDe" in checkDataColNames() API,  the serde 
name shall be "org.apache.hadoop.hive.ql.io.parquet.serde.ParquetHiveSerDe" for 
parquet, so i added this serde also in above code as part of 
checkDataColNames()  API.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to