gengliangwang commented on a change in pull request #24094: [SPARK-27162][SQL]
Add new method getOriginalMap in CaseInsensitiveStringMap
URL: https://github.com/apache/spark/pull/24094#discussion_r265653298
##########
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/util/CaseInsensitiveStringMap.java
##########
@@ -78,11 +81,13 @@ public String get(Object key) {
@Override
public String put(String key, String value) {
+ originalMap.put(key, value);
Review comment:
Things become a bit ambiguous here. E.g. after `put("a", "b")` and `put("A",
"B")` to a empty `CaseInsensitiveStringMap`, `originalMap` has two new entries,
while `delegate` has only one new entry.
To me, this is the simplest way to maintain `originalMap`. Suggestions are
welcomed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
