mwlon commented on a change in pull request #24085: [SPARK-26555][SQL] make
ScalaReflection subtype checking thread safe
URL: https://github.com/apache/spark/pull/24085#discussion_r265689594
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
##########
@@ -66,19 +66,25 @@ object ScalaReflection extends ScalaReflection {
*/
def dataTypeFor[T : TypeTag]: DataType = dataTypeFor(localTypeOf[T])
+ private[catalyst] def isSubtype(tpe1: `Type`, tpe2: `Type`): Boolean = {
+ this.synchronized {
+ tpe1 <:< tpe2
Review comment:
In my experiments it does. Are you familiar with a situation where it might
not?
One thing I'm not totally certain about is whether it's more efficient
(performance-wise) to lock here (which means accessing the lock many times per
function) vs. locking once each function.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]