vanzin commented on a change in pull request #24088: [SPARK-27122][core] Jetty
classes must not be return via getters in org.apache.spark.ui.WebUI
URL: https://github.com/apache/spark/pull/24088#discussion_r265724871
##########
File path: core/src/main/scala/org/apache/spark/ui/WebUI.scala
##########
@@ -95,6 +101,16 @@ private[spark] abstract class WebUI(
serverInfo.foreach(_.addHandler(handler, securityManager))
}
+ /** Attaches a handler to this UI. */
+ def attachNewHandler(contextPath: String,
Review comment:
This doesn't follow Spark's multi-line argument style. Also in all your
other methods.
For this particular method, the `New` in the name is unnecessary. It just
raises questions about why this handler is "new" and the others aren't.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
