srowen commented on a change in pull request #24086: [SPARK-27155][Build]update
oracle docker image name
URL: https://github.com/apache/spark/pull/24086#discussion_r265987157
##########
File path:
external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleIntegrationSuite.scala
##########
@@ -55,7 +55,8 @@ class OracleIntegrationSuite extends
DockerJDBCIntegrationSuite with SharedSQLCo
import testImplicits._
override val db = new DatabaseOnDocker {
- override val imageName = "wnameless/oracle-xe-11g:16.04"
+ override val imageName =
sys.env.getOrElse("SPARK_ORACLE_DOCKER_IMAGE_NAME",
+ "wnameless/oracle-xe-11g:16.04")
Review comment:
We can't even have a default; this default doesn't work
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
