rdblue commented on a change in pull request #24094: [SPARK-27162][SQL] Add new
method getOriginalMap in CaseInsensitiveStringMap
URL: https://github.com/apache/spark/pull/24094#discussion_r266174167
##########
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/util/CaseInsensitiveStringMap.java
##########
@@ -78,11 +81,13 @@ public String get(Object key) {
@Override
public String put(String key, String value) {
+ original.put(key, value);
Review comment:
That works for me. It is always a good idea to avoid passing mutable state
to plugin code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
