weixiuli commented on a change in pull request #23393: [SPARK-26288][CORE]add
initRegisteredExecutorsDB
URL: https://github.com/apache/spark/pull/23393#discussion_r266180689
##########
File path: core/src/main/scala/org/apache/spark/internal/config/Worker.scala
##########
@@ -30,7 +30,7 @@ private[spark] object Worker {
val WORKER_CLEANUP_ENABLED = ConfigBuilder("spark.worker.cleanup.enabled")
.booleanConf
- .createWithDefault(false)
+ .createWithDefault(true)
Review comment:
As ,this commit depend on WORKER_CLEANUP_ENABLED . While ,we should keep
the default value of `spark.worker.cleanup.enabled `= false . But ,We should
make it clear in the docs that `spark.worker.cleanup.enabled` should be enabled
if spark.shuffle.service.db.enabled is "true”, all right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
