mccheah commented on a change in pull request #23848: [SPARK-26946][SQL]
Identifiers for multi-catalog
URL: https://github.com/apache/spark/pull/23848#discussion_r266182409
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -95,13 +96,40 @@ object AnalysisContext {
class Analyzer(
catalog: SessionCatalog,
conf: SQLConf,
- maxIterations: Int)
+ maxIterations: Int,
+ lookupCatalog: Option[(String) => CatalogPlugin] = None)
extends RuleExecutor[LogicalPlan] with CheckAnalysis {
def this(catalog: SessionCatalog, conf: SQLConf) = {
this(catalog, conf, conf.optimizerMaxIterations)
}
+ def this(lookupCatalog: Option[(String) => CatalogPlugin], catalog:
SessionCatalog,
+ conf: SQLConf) = {
+ this(catalog, conf, conf.optimizerMaxIterations, lookupCatalog)
+ }
+
+ object CatalogRef {
+ def unapply(parts: Seq[String]): Option[(Option[CatalogPlugin],
CatalogIdentifier)] =
Review comment:
To clarify because Github isn't putting your comment in a thread, is this in
response to https://github.com/apache/spark/pull/23848#discussion_r266179932?
If so, is "I like this" meaning "I like the case class" that above comment has
suggested, or, that you prefer the way it is currently?
Just trying to disambiguate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
