ajithme commented on a change in pull request #24100: [SPARK-27164] 
RDD.countApprox on empty RDDs schedules jobs which never complete
URL: https://github.com/apache/spark/pull/24100#discussion_r266188557
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
 ##########
 @@ -1239,6 +1239,9 @@ private[spark] class DAGScheduler(
           markMapStageJobsAsFinished(stage)
         case stage : ResultStage =>
           logDebug(s"Stage ${stage} is actually done; (partitions: 
${stage.numPartitions})")
 
 Review comment:
   @cloud-fan, ``RDD#count`` scenario is handled via ``submitJob`` as initially 
we have a ``partitions.size==0`` check, just like @squito mentioned
   
   @squito so do you suggest i provide a similar check in 
``runApproximateJob``.?? shall i change this PR.?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to