wangyum commented on a change in pull request #24115: 
[SPARK-27180][BUILD][YARN] Fix testing issues with yarn module in Hadoop-3
URL: https://github.com/apache/spark/pull/24115#discussion_r266193033
 
 

 ##########
 File path: 
resource-managers/yarn/src/test/java/org/apache/hadoop/net/ServerSocketUtil.java
 ##########
 @@ -0,0 +1,132 @@
+/*
 
 Review comment:
   Add this class. otherwise:
   ```
   [info] YarnClusterSuite:
   [info] org.apache.spark.deploy.yarn.YarnClusterSuite *** ABORTED *** (33 
milliseconds)
   [info]   java.lang.NoClassDefFoundError: 
org/apache/hadoop/net/ServerSocketUtil
   [info]   at 
org.apache.hadoop.yarn.server.MiniYARNCluster.serviceInit(MiniYARNCluster.java:260)
   ```
   I try to do it by maven, but failed. It seems that [`sbt-pom-reader` does 
not support `test-jar`](https://github.com/sbt/sbt-pom-reader/pull/#14) very 
well.:
   
   ```xml
       <dependency>
         <groupId>org.apache.hadoop</groupId>
         <artifactId>hadoop-common</artifactId>
         <version>${hadoop.version}</version>
         <type>test-jar</type>
         <scope>test</scope>
         <exclusions>
           <exclusion>
             <groupId>*</groupId>
             <artifactId>*</artifactId>
           </exclusion>
         </exclusions>
       </dependency>
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to