HeartSaVioR commented on a change in pull request #24113: [MINOR][CORE] Replace
Scala forkjoin package to Java bundled one
URL: https://github.com/apache/spark/pull/24113#discussion_r266290735
##########
File path: core/src/main/scala/org/apache/spark/util/ThreadUtils.scala
##########
@@ -181,17 +180,17 @@ private[spark] object ThreadUtils {
}
/**
- * Construct a new Scala ForkJoinPool with a specified max parallelism and
name prefix.
+ * Construct a new ForkJoinPool with a specified max parallelism and name
prefix.
*/
- def newForkJoinPool(prefix: String, maxThreadNumber: Int): SForkJoinPool = {
+ def newForkJoinPool(prefix: String, maxThreadNumber: Int): ForkJoinPool = {
Review comment:
Sorry I missed we are still supporting Scala-2.11. It wouldn't even compile
for Scala-2.11 because of the parameter type of ForkJoinTaskSupport. Thanks for
pointing it out!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
