Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/3734#discussion_r22085929
--- Diff:
network/shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockManager.java
---
@@ -60,8 +61,11 @@
private final TransportConf conf;
public ExternalShuffleBlockManager(TransportConf conf) {
- // TODO: Give this thread a name.
- this(conf, Executors.newSingleThreadExecutor());
+ this(conf, Executors.newSingleThreadExecutor(
--- End diff --
Should it be `daemon` or not? If it's daemon, it may not have enough time
to delete all files when the service is exiting.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
