asmello commented on a change in pull request #23882: [SPARK-26979][PYTHON] Add
missing string column name support for some SQL functions
URL: https://github.com/apache/spark/pull/23882#discussion_r266340892
##########
File path: python/pyspark/sql/functions.py
##########
@@ -1437,10 +1453,6 @@ def hash(*cols):
'ascii': 'Computes the numeric value of the first character of the string
column.',
'base64': 'Computes the BASE64 encoding of a binary column and returns it
as a string column.',
'unbase64': 'Decodes a BASE64 encoded string column and returns it as a
binary column.',
- 'initcap': 'Returns a new string column by converting the first letter of
each word to ' +
- 'uppercase. Words are delimited by whitespace.',
- 'lower': 'Converts a string column to lower case.',
- 'upper': 'Converts a string column to upper case.',
Review comment:
The java/scala API documentation says it was added in 1.3, but I just
tracked down the JIRA/PR and it seems it actually was 1.0.
https://issues.apache.org/jira/browse/SPARK-1995
https://github.com/apache/spark/pull/936
As for removing overwritten functions, maybe it would've been better to make
a separate PR, but the first fix did require removing them. When I changed the
approach it seemed reasonable to keep the change, since the problem was obvious
and easy to fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
