HeartSaVioR commented on a change in pull request #24128: [SPARK-27188][SS] FileStreamSink: provide a new option to disable metadata log URL: https://github.com/apache/spark/pull/24128#discussion_r266375335
########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/ManifestFileCommitProtocol.scala ########## @@ -40,14 +40,14 @@ class ManifestFileCommitProtocol(jobId: String, path: String) // Track the list of files added by a task, only used on the executors. @transient private var addedFiles: ArrayBuffer[String] = _ - @transient private var fileLog: FileStreamSinkLog = _ + @transient private var fileLog: MetadataLog[Array[SinkFileStatus]] = _ Review comment: This is necessary to not having branch on mode, but we can still apply `asInstanceOf` (with `require`) and keep this as it is. Please let me know what's our preference. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
