sujith71955 commented on issue #24075: [SPARK-26176][SQL] Verify column names for CTAS with `STORED AS` URL: https://github.com/apache/spark/pull/24075#issuecomment-473867192 Nope, i unified this for ctas queries, if non ctas query still flow is same, means the validation will be done from HiveAnalysis and DatasourceAnalysis rule. Shall we unify that layer also? Let me know. Thanks On Mon, 18 Mar 2019 at 4:33 PM, Wenchen Fan <[email protected]> wrote: > *@cloud-fan* commented on this pull request. > ------------------------------ > > In > sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala > <https://github.com/apache/spark/pull/24075#discussion_r266388573>: > > > @@ -206,6 +206,8 @@ case class PreprocessTableCreation(sparkSession: SparkSession) extends Rule[Logi > val analyzedQuery = query.get > val normalizedTable = normalizeCatalogTable(analyzedQuery.schema, tableDesc) > > + DDLUtils.checkDataColNames(tableDesc.copy(schema = analyzedQuery.schema)) > > did we call this in the else branch? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/spark/pull/24075#pullrequestreview-215534021>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AMZZ-ckORUozuZixUkdWSCUbDBTw9doCks5vX3KWgaJpZM4br_0p> > . >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
