skonto commented on a change in pull request #23599: [SPARK-24793][K8s] Enhance
spark-submit for app management
URL: https://github.com/apache/spark/pull/23599#discussion_r266479309
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
##########
@@ -325,6 +325,12 @@ private[spark] object Config extends Logging {
.booleanConf
.createWithDefault(true)
+ val KUBERNETES_SUBMIT_GRACE_PERIOD =
+ ConfigBuilder("spark.kubernetes.submitGracePeriod")
+ .doc("Number of seconds that should be used to wait for graceful
deletion of Spark pods.")
+ .longConf
Review comment:
Ok will fix just but grace period should be small actually it does not make
much sense to have an arbitrary time unit like days or something. @vanzin that
is why I set seconds "The kubectl delete command supports the
--grace-period=<seconds>"
https://kubernetes.io/docs/concepts/workloads/pods/pod/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
