attilapiros commented on a change in pull request #24132: [SPARK-27189][CORE]
Add executor-level memory usage metrics to the metrics system
URL: https://github.com/apache/spark/pull/24132#discussion_r266530150
##########
File path:
core/src/main/scala/org/apache/spark/metrics/source/MemorySource.scala
##########
@@ -71,75 +71,73 @@ private[spark] class MemorySource extends Source {
val METRIC_PROCESS_TREE_OTHER_RSSMEMORY =
metricRegistry.counter(MetricRegistry.name("ProcessTreeOtherRSSMemory"))
- def updateCounters(memorySource: MemorySource,
- metricsUpdates: ExecutorMetrics): Unit = {
-
- memorySource.METRIC_JVM_HEAP_MEMORY.inc(
+ def updateCounters(metricsUpdates: ExecutorMetrics): Unit = {
+ this.METRIC_JVM_HEAP_MEMORY.inc(
Review comment:
The `this.` is not needed as implicitly there when you leave it out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
