dongjoon-hyun edited a comment on issue #24099: [SPARK-27168][TEST] Add docker integration test for MsSql server URL: https://github.com/apache/spark/pull/24099#issuecomment-474006444 @lipzhu . If you clear your maven repository and run `./build/mvn test -Pdocker-integration-tests -pl :spark-docker-integration-tests_2.12`, you can see the failure. For Apache Spark contribution, I'd like to recommend you the followings. - To get a correct review, the PR itself should be a complete code, but this is not. Although Jenkins builds PRs after rebasing, please don't assume that the reviewer to rebase your PR to the `master` branch. Technically, we need https://github.com/apache/spark/commit/8ee09f26d51dd0acdbada9c4d3d2baee05a7f786 in this PR, isn't it? - Before testing locally, please remove your local maven repository. It's an essential step for sanity. Docker integration suite uses the snapshot artifacts in the following location. However, your previous PR is not published there yet. - https://repository.apache.org/content/groups/snapshots/org/apache/spark/spark-sql_2.12/3.0.0-SNAPSHOT/ Due to (1) and (2), only you pass the test locally. Technically, this PR needs three following steps. Otherwise, it fails. 1. Rebased this PR to bring the previous patch. 2. Do `mvn clean -DskipTests install`. 3. Run `build/mvn test -Pdocker-integration-tests -pl :spark-docker-integration-tests_2.12`. Lastly, please update `How was this patch tested?` section in this PR description. Otherwise, we need to wait the snapshot artifacts are ready.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
