vanzin commented on issue #23843: [SPARK-26938][CORE]fill taskMetrics to SparkListenerTaskEnd Event even though task is failed URL: https://github.com/apache/spark/pull/23843#issuecomment-474023002 Ok, I think I'm getting it. You're modifying the behavior of the live application, writing the data to the event log, so that the SHS can read it later? BTW that's the kind of thing you use the PR description for. Reading your description doesn't clarify what you're trying to do at all. I'm still not a fan of the change though. It feels like the wrong place to do this. At worst, the event logging listener could do it, since that's the part of the code that's preparing data for the SHS.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
