zsxwing commented on a change in pull request #22282: [SPARK-23539][SS] Add 
support for Kafka headers in Structured Streaming
URL: https://github.com/apache/spark/pull/22282#discussion_r266613666
 
 

 ##########
 File path: 
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriteTask.scala
 ##########
 @@ -88,7 +92,30 @@ private[kafka010] abstract class KafkaRowWriter(
       throw new NullPointerException(s"null topic present in the data. Use the 
" +
         s"${KafkaSourceProvider.TOPIC_OPTION_KEY} option for setting a default 
topic.")
     }
-    val record = new ProducerRecord[Array[Byte], Array[Byte]](topic.toString, 
key, value)
+    val record = if (projectedRow.isNullAt(3)) {
+      new ProducerRecord[Array[Byte], Array[Byte]](
+        topic.toString,
+        null,
+        key,
+        value
+      )
+    } else {
+      val headerMap = projectedRow.getMap(3)
+      val headers = (0 until headerMap.numElements()).toArray.map(
+        i =>
+          new RecordHeader(
 
 Review comment:
   Looks like the Kafka community didn't reply. Since adding a new class is 
just several lines, let's just add it to avoid using internal classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to