HeartSaVioR commented on a change in pull request #24128: [SPARK-27188][SS]
FileStreamSink: provide a new option to have retention on output files
URL: https://github.com/apache/spark/pull/24128#discussion_r266693734
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FileStreamSinkLog.scala
##########
@@ -45,7 +46,20 @@ case class SinkFileStatus(
modificationTime: Long,
blockReplication: Int,
blockSize: Long,
- action: String) {
+ action: String,
+ commitTime: Long) {
+
+ def this(
+ path: String,
+ size: Long,
+ isDir: Boolean,
+ modificationTime: Long,
+ blockReplication: Int,
+ blockSize: Long,
+ action: String) {
+ // use modification time if we don't know about exact commit time
Review comment:
If we concern about dealing with Hadoop timestamp / timezone, we can just
set it to `Long.MaxValue`. This means existing entries in metadata will not be
affected by the change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
