Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/3721#discussion_r22091804
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/util/WriteAheadLogManager.scala
---
@@ -125,7 +125,7 @@ private[streaming] class WriteAheadLogManager(
* between the node calculating the threshTime (say, driver node), and
the local system time
* (say, worker node), the caller has to take account of possible time
skew.
*/
- def cleanupOldLogs(threshTime: Long): Unit = {
+ def cleanupOldLogs(threshTime: Long): Future[Unit] = {
--- End diff --
> The thing is that deleting asynchronously is an implementation detail -
which we choose to do now, which can be changed later, don't you think? If we
change it later, we'd have to change this method's signature - which can cause
pain if there is code that uses Await.result(*) on this future.
I doubt if it will be changed. However, `asynchronously` is an important
implementation detail that the caller should know it, or they may misuse it.
> If we expose it via a parameter, we can choose to ignore the param and
still the calling code will not have to change. Since it is unlikely that the
calling code will actually depend on the async nature, it is unlikely to see
any difference in functionality and no change in code is required.
I don't think a parameter is enough. At least, it needs a more parameter, a
`timeout` parameter. In your PR, you used `1 second` which may not be enough.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
