hehuiyuan commented on a change in pull request #24123:
[SPARK-27184][CORE]Replace 'spark.jars' & 'spark.files' with the variables of
this confi…
URL: https://github.com/apache/spark/pull/24123#discussion_r266763433
##########
File path: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala
##########
@@ -542,10 +542,10 @@ private[spark] class SparkSubmit extends Logging {
OptionAssigner(args.totalExecutorCores, STANDALONE | MESOS | KUBERNETES,
ALL_DEPLOY_MODES,
confKey = CORES_MAX.key),
OptionAssigner(args.files, LOCAL | STANDALONE | MESOS | KUBERNETES,
ALL_DEPLOY_MODES,
- confKey = "spark.files"),
- OptionAssigner(args.jars, LOCAL, CLIENT, confKey = "spark.jars"),
+ confKey = FILES.key),
+ OptionAssigner(args.jars, LOCAL, CLIENT, confKey = JARS.key),
OptionAssigner(args.jars, STANDALONE | MESOS | KUBERNETES,
ALL_DEPLOY_MODES,
- confKey = "spark.jars"),
Review comment:
In the org.apache.spark.internal.config，many variables have been defined
and used them elsewhere.
But 'spark.jars' and 'spark.files' are not used in the SparkContext and
Submit.
I mean, we can use the variables of FILES and JARS instead of "spark.jars"
and "spark.files".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
