viirya commented on a change in pull request #24121:
[SPARK-26979][PYTHON][FOLLOW-UP] Make binary math/string functions take string
as columns as well
URL: https://github.com/apache/spark/pull/24121#discussion_r266764911
##########
File path: python/pyspark/sql/tests/test_functions.py
##########
@@ -151,7 +157,8 @@ def test_rand_functions(self):
self.assertEqual(sorted(rndn1), sorted(rndn2))
def test_string_functions(self):
- from pyspark.sql.functions import col, lit
+ from pyspark.sql import functions
+ from pyspark.sql.functions import col, lit, upper, _string_functions
Review comment:
why import `upper`, I don't see it is used here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
