ajithme commented on issue #24140: [SPARK-27198][core] Heartbeat interval mismatch in driver and executor URL: https://github.com/apache/spark/pull/24140#issuecomment-474284343 > The changes can break existing users apps in the case if the suffix is not set. Let's say there is an app for Spark 2.4 which set 10000 (10 sec) as `spark.executor.heartbeatInterval`. After your changes, it become 1000 * 10 sec. Isn't it? > > Could you write a test when there is no suffix, and `spark.executor.heartbeatInterval` is set to 10000? 1. No it doesnt break. If in 2.4, user has configured ``spark.executor.heartbeatInterval=10000``, **without my change**, the driver assumes it as 10000 seconds but executor assumes it as 10 seconds, so functionality is already broken 2. Will update with a testcase
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
