maropu commented on a change in pull request #24047: [SPARK-25196][SQL] Extends
the analyze column command for cached tables
URL: https://github.com/apache/spark/pull/24047#discussion_r266864599
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeColumnCommand.scala
##########
@@ -89,6 +97,35 @@ case class AnalyzeColumnCommand(
columnsToAnalyze
}
+ private def analyzeColumnInCatalog(sparkSession: SparkSession): Unit = {
+ val sessionState = sparkSession.sessionState
+ val tableMeta = sessionState.catalog.getTableMetadata(tableIdent)
+ if (tableMeta.tableType == CatalogTableType.VIEW) {
+ throw new AnalysisException("ANALYZE TABLE is not supported on views.")
Review comment:
It seems we can do the same fix for AnalyzeTableCommand:
https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeTableCommand.scala#L38
If no problem, I'll do in a separate follow-up pr.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
