s1ck commented on a change in pull request #24107: [SPARK-27174][SQL] Add 
support for casting integer types to binary
URL: https://github.com/apache/spark/pull/24107#discussion_r266903447
 
 

 ##########
 File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
 ##########
 @@ -1382,3 +1389,44 @@ case class UpCast(child: Expression, dataType: 
DataType, walkedTypePath: Seq[Str
   extends UnaryExpression with Unevaluable {
   override lazy val resolved = false
 }
+
+object ToBinary {
 
 Review comment:
   I moved the conversion logic into `NumberConverter`, an already existing 
utility object and added tests to the `NumberConverterSuite`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to