xuanyuanking commented on issue #24110: [SPARK-25341][Core] Support rolling back a shuffle map stage and re-generate the shuffle files URL: https://github.com/apache/spark/pull/24110#issuecomment-474424797 ``` To help other people review this patch, can you add the following information in your PR description? ``` Thanks Wenchen, the PR description updated. ``` A side question: can we skip the temp file when writing shuffle files? ``` Maybe the temp file is still needed because, in this PR, the attempt number in the file name is the stage attempt id for indeterminate stage, not the task attempt id, so there's still possible for the same partition on the same executor in each stage.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
