MaxGekk commented on a change in pull request #24141: [SPARK-27199][SQL]
Replace TimeZone by ZoneId in TimestampFormatter API
URL: https://github.com/apache/spark/pull/24141#discussion_r266982488
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/TimestampFormatter.scala
##########
@@ -43,18 +43,17 @@ sealed trait TimestampFormatter extends Serializable {
}
class Iso8601TimestampFormatter(
- pattern: String,
- timeZone: TimeZone,
- locale: Locale) extends TimestampFormatter with DateTimeFormatterHelper {
+ pattern: String,
Review comment:
thanx. Just wondering why `scalastyle` didn't catch that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
