rdblue commented on a change in pull request #24129: [SPARK-27190][SQL] add
table capability for streaming
URL: https://github.com/apache/spark/pull/24129#discussion_r267032631
##########
File path:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala
##########
@@ -353,13 +354,15 @@ private[kafka010] class KafkaSourceProvider extends
DataSourceRegister
}
class KafkaTable(strategy: => ConsumerStrategy) extends Table
- with SupportsMicroBatchRead with SupportsContinuousRead with
SupportsStreamingWrite {
+ with SupportsRead with SupportsWrite {
Review comment:
I don't think of these as super-capabilities, I think of them as a link
between the v2 catalog API and the v2 source API. Using a trait like
`SupportsRead` means we can later make changes to either one and continue to
use the other. For example, if we added a `Stream` abstraction instead of using
`Table` for both, then we would be able to have `Stream` implement
`SupportsRead`. Does that make sense?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
