ajithme commented on a change in pull request #24140: [SPARK-27198][core] 
Heartbeat interval mismatch in driver and executor
URL: https://github.com/apache/spark/pull/24140#discussion_r267083616
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
 ##########
 @@ -855,7 +855,9 @@ private[spark] class Executor(
    * Schedules a task to report heartbeat and partial metrics for active tasks 
to driver.
    */
   private def startDriverHeartbeater(): Unit = {
-    val intervalMs = conf.getTimeAsMs("spark.executor.heartbeatInterval", 
"10s")
+    val intervalMs = conf
 
 Review comment:
   okay, seems more reasonable as it also avoids  the scenario @MaxGekk 
mentioned. Will modify the PR accordingly

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to