zsxwing commented on a change in pull request #19096: [SPARK-21869][SS] A
cached Kafka producer should not be closed if any task is using it - adds inuse
tracking.
URL: https://github.com/apache/spark/pull/19096#discussion_r267124993
##########
File path:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriteTask.scala
##########
@@ -50,17 +51,16 @@ private[kafka010] class KafkaWriteTask(
def close(): Unit = {
checkForErrors()
- if (producer != null) {
- producer.flush()
- checkForErrors()
- producer = null
- }
+ producer.flush()
+ checkForErrors()
+ CachedKafkaProducer.release(producer, failedWrite != null)
}
}
private[kafka010] abstract class KafkaRowWriter(
- inputSchema: Seq[Attribute], topic: Option[String]) {
+ inputSchema: Seq[Attribute], topic: Option[String]) extends Logging {
Review comment:
nit: unnecessary change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
