Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3725#discussion_r22097263
--- Diff: core/src/main/scala/org/apache/spark/TestUtils.scala ---
@@ -43,9 +43,19 @@ private[spark] object TestUtils {
* Note: if this is used during class loader tests, class names should
be unique
* in order to avoid interference between tests.
*/
- def createJarWithClasses(classNames: Seq[String], value: String = ""):
URL = {
+ def createJarWithClasses(
+ classNames: Seq[String],
+ value: String = "",
+ classpathUrls: Seq[URL] = Seq()): URL = {
val tempDir = Utils.createTempDir()
- val files = for (name <- classNames) yield createCompiledClass(name,
tempDir, value)
+ val files = for (name <- classNames) yield {
+ if (name.indexOf(" ") == -1) {
--- End diff --
How about a method taking `Seq[(String,String)]` instead as an overload for
this case?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
