Github user srowen commented on the pull request:

    https://github.com/apache/spark/pull/3157#issuecomment-67630085
  
    Sorry for the noise on this one. I couldn't figure out why the test was 
failing after a rebase, but I figured it out. I think that, in the process of 
fixing the warning, it actually fixed the test, and, reveals a small problem in 
the test.
    
    In 
https://github.com/apache/spark/blob/master/sql/core/src/test/scala/org/apache/spark/sql/parquet/ParquetQuerySuite.scala#L487
 it looks like it should really be
    
    ```
        checkFilter[Operators.NotEq[Integer]](!('a.int === 1))`
    ```
    
    instead of
    
    ```
        checkFilter[Operators.Not](!('a.int === 1))
    ```
    
    @liancheng does that make sense to you? I think this was the commit with 
the test:
    
https://github.com/apache/spark/commit/423baea953996a66dde671ff6db2fb1f32fbe8cb


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to