Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/3742#issuecomment-67657107
LGTM. It looks like this properly uses `getBytes()` by also using
`getLength()` to determine which subarray of the `getBytes()` result contains
valid data (see
[HADOOP-6298](https://issues.apache.org/jira/browse/HADOOP-6298)).
I suppose this could use `Arrays.copyOfRange` to cut out one line (like was
done in
https://github.com/apache/spark/commit/fc616d51a510f82627b5be949a5941419834cf70#diff-364713d7776956cb8b0a771e9b62f82dR1435),
but that's just a minor thing, so I'm going to merge this to fix the Hadoop 1
build. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
