dongjoon-hyun commented on a change in pull request #24005: [SPARK-27085][SQL]
Migrate CSV to File Data Source V2
URL: https://github.com/apache/spark/pull/24005#discussion_r267461511
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala
##########
@@ -359,24 +359,25 @@ class FileBasedDataSourceSuite extends QueryTest with
SharedSQLContext with Befo
spark.range(1).write.format(format).mode("overwrite").save(tempDir)
spark.read.schema(schema).format(format).load(tempDir).collect()
}.getMessage
- assert(msg.toLowerCase(Locale.ROOT).contains(errorMessage(format,
false)))
+ validateErrorMessage(msg)
msg = intercept[AnalysisException] {
val schema = StructType(StructField("a", new IntervalUDT(),
true) :: Nil)
spark.range(1).write.format(format).mode("overwrite").save(tempDir)
spark.read.schema(schema).format(format).load(tempDir).collect()
}.getMessage
- assert(msg.toLowerCase(Locale.ROOT).contains(errorMessage(format,
false)))
+ validateErrorMessage(msg)
}
}
}
}
}
test("SPARK-24204 error handling for unsupported Null data types - csv,
parquet, orc") {
+ // TODO: test file source V2 after write path is fixed.
Seq(true).foreach { useV1 =>
val useV1List = if (useV1) {
- "orc"
+ "orc,csv"
Review comment:
nit. `csv,orc`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
