dilipbiswal commented on a change in pull request #24150: [SPARK-27209][SQL]
Split parsing of SELECT and INSERT into two top-level rules in the grammar file.
URL: https://github.com/apache/spark/pull/24150#discussion_r267523593
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/PlanParserSuite.scala
##########
@@ -754,4 +754,29 @@ class PlanParserSuite extends AnalysisTest {
assertEqual(query2, Distinct(a.union(b)).except(c.intersect(d, isAll =
true), isAll = true))
}
}
+
+ test("create/alter view as insert into table") {
+ intercept[ParseException](parsePlan("CREATE VIEW testView AS INSERT INTO
jt VALUES(1, 1)"))
Review comment:
@dongjoon-hyun For parser exceptions, we would have list of expected tokens
which may change in future to make this a little fragile (we may need to update
the error message frequently) ? Thats why i didn't check the exact message text
here.
if you want it checked, would it be better to put it in SQlQueryTestSuite
(perhaps easy to regenerate the output file) ? Let me know what you think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
