zsxwing commented on a change in pull request #24154: [SPARK-27210][SS] Cleanup incomplete output files in ManifestFileCommitProtocol if task is aborted URL: https://github.com/apache/spark/pull/24154#discussion_r267565957
########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/ManifestFileCommitProtocol.scala ########## @@ -43,6 +43,9 @@ class ManifestFileCommitProtocol(jobId: String, path: String) @transient private var fileLog: FileStreamSinkLog = _ private var batchId: Long = _ + /** returns copied version of addedFiles: only unit tests purpose */ + private[sql] def getAddedFiles: Array[String] = Array(addedFiles: _*) Review comment: this method is not needed once you remove TaskFailToCommitManifestFileCommitProtocol ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
