RussellSpitzer commented on a change in pull request #23848: [SPARK-26946][SQL] Identifiers for multi-catalog URL: https://github.com/apache/spark/pull/23848#discussion_r267594937
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalog/v2/LookupCatalog.scala ########## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.catalog.v2 + +import org.apache.spark.annotation.Experimental +import org.apache.spark.sql.catalyst.TableIdentifier + +@Experimental +trait LookupCatalog { + + def lookupCatalog: Option[(String) => CatalogPlugin] = None + + type CatalogObjectIdentifier = (Option[CatalogPlugin], Identifier) + + object CatalogObjectIdentifier { + def unapply(parts: Seq[String]): Option[CatalogObjectIdentifier] = lookupCatalog.map { lookup => + parts match { + case Seq(name) => + (None, Identifier.of(Array.empty, name)) + case Seq(catalogName, tail @ _*) => + try { + val catalog = lookup(catalogName) + (Some(catalog), Identifier.of(tail.init.toArray, tail.last)) + } catch { + case _: CatalogNotFoundException => + (None, Identifier.of(parts.init.toArray, parts.last)) + } + } + } + } + + object AsTableIdentifier { Review comment: We may want to highlight that this is an extractor for supporting old legacy use-cases, modern rules and such should use CatalogObjectIdentifier and assume multipart extraction? Just a comment on the code for future dev's using these extractors and wondering which they should implement. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
