srowen commented on a change in pull request #24166: [SPARK-27226][SQL] Reduce
the code duplicate when upgrading built-in Hive
URL: https://github.com/apache/spark/pull/24166#discussion_r267827381
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcTest.scala
##########
@@ -104,4 +108,32 @@ abstract class OrcTest extends QueryTest with
FileBasedDataSourceTest with Befor
assert(actual < numRows)
}
}
+
+ protected def checkNoFilterPredicate
+ (predicate: Predicate, noneSupported: Boolean = false)
+ (implicit df: DataFrame): Unit = {
+ val output = predicate.collect { case a: Attribute => a }.distinct
+ val query = df
+ .select(output.map(e => Column(e)): _*)
Review comment:
No big deal, but `.map(Column)`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
