viirya commented on a change in pull request #24150: [SPARK-27209][SQL] Split
parsing of SELECT and INSERT into two top-level rules in the grammar file.
URL: https://github.com/apache/spark/pull/24150#discussion_r267833598
##########
File path:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -354,9 +355,14 @@ resource
: identifier STRING
;
+insertStatement
+ : (ctes)? insertInto queryTerm queryOrganization
#singleInsertQuery
+ | (ctes)? fromClause multiInsertQueryBody+
#multiInsertQuery
+ ;
+
queryNoWith
- : insertInto? queryTerm queryOrganization
#singleInsertQuery
- | fromClause multiInsertQueryBody+
#multiInsertQuery
+ : queryTerm queryOrganization
#noWithQuery
+ | fromClause querySpecification queryOrganization
#queryWithFrom
Review comment:
Previously there can be multiple `multiInsertQueryBody`. Looks like there
will be an Union for the inserts. Because the `insertInto` is optional, I think
it can a `fromClause` and multiple `querySpecification queryOrganization`. But
looks like the new rule doesn't allow it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
