HyukjinKwon commented on a change in pull request #24123: [SPARK-27184][CORE]
Replace 'spark.jars' & 'spark.files' with the variables of this config object
URL: https://github.com/apache/spark/pull/24123#discussion_r268014305
##########
File path: core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala
##########
@@ -681,7 +681,7 @@ class SparkSubmitSuite
appArgs.jars should be(Utils.resolveURIs(jars))
appArgs.files should be(Utils.resolveURIs(files))
conf.get(JARS) should be(Utils.resolveURIs(jars +
",thejar.jar").split(",").toSeq)
- conf.get("spark.files") should be(Utils.resolveURIs(files))
+ conf.get(FILES) should be(Utils.resolveURIs(files))
Review comment:
`FILES` -> `FILES.key` so that it reads it as string like the previous case,
or make `Utils.resolveURIs(files)` ->
`Utils.resolveURIs(files).split(",").toSeq` to match with the case above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
