HeartSaVioR commented on a change in pull request #24173: [SPARK-27237][SS]
Introduce State schema validation among query restart
URL: https://github.com/apache/spark/pull/24173#discussion_r268158450
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStore.scala
##########
@@ -361,9 +361,12 @@ object StateStore extends Logging {
val storeProvider = loadedProviders.synchronized {
startMaintenanceIfNeeded()
val provider = loadedProviders.getOrElseUpdate(
- storeProviderId,
- StateStoreProvider.createAndInit(
- storeProviderId.storeId, keySchema, valueSchema, indexOrdinal,
storeConf, hadoopConf)
+ storeProviderId, {
Review comment:
Yeah that sounds better. I think we can place in prior to create provider to
avoid creating provider if schema validation fails.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
