attilapiros commented on a change in pull request #24123: [SPARK-27184][CORE]
Avoid hardcoded 'spark.jars', 'spark.files', 'spark.submit.pyFiles' and
'spark.submit.deployMode'
URL: https://github.com/apache/spark/pull/24123#discussion_r268213131
##########
File path:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala
##########
@@ -183,9 +183,9 @@ private[deploy] class SparkSubmitArguments(args:
Seq[String], env: Map[String, S
.orElse(sparkProperties.get(config.CORES_MAX.key))
.orNull
name = Option(name).orElse(sparkProperties.get("spark.app.name")).orNull
- jars = Option(jars).orElse(sparkProperties.get("spark.jars")).orNull
- files = Option(files).orElse(sparkProperties.get("spark.files")).orNull
- pyFiles =
Option(pyFiles).orElse(sparkProperties.get("spark.submit.pyFiles")).orNull
+ jars = Option(jars).orElse(sparkProperties.get(config.JARS.key)).orNull
+ files = Option(files).orElse(sparkProperties.get(config.FILES.key)).orNull
+ pyFiles =
Option(pyFiles).orElse(sparkProperties.get(config.SUBMIT_PYTHON_FILES.key)).orNull
Review comment:
What I meant is keeping your change well focused. If the PR is about
'spark.jars' and 'spark.files' then I would expect only those to be modified
and if you change any other config then I think it is good to add it to the
title and/or description to know the reason of the change when the git log is
read. Moreover in this case I would expect those touched configs to be
corrected everywhere else too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
