attilapiros commented on issue #24127: [SPARK-27186][CORE] optimize sortshuffle write URL: https://github.com/apache/spark/pull/24127#issuecomment-475749687 @srowen I think it is very hard to refactor this 3-4 lines into a common method as for `SortShuffleWriter.write` the new method should write the `mapStatus` member (which can be solved by passing this `mapStatus` as the return value of the new method) but for `BypassMergeSortShuffleWriter.write` there is two members which should be set (`mapStatus` and `partitionLengths`).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
