vanzin commented on a change in pull request #23951: [SPARK-13704][CORE][YARN]
Re-implement RackResolver to reduce resolving time
URL: https://github.com/apache/spark/pull/23951#discussion_r268351110
##########
File path: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala
##########
@@ -214,7 +229,10 @@ private[spark] class TaskSetManager(
private[scheduler] var emittedTaskSizeWarning = false
/** Add a task to all the pending-task lists that it should be on. */
- private[spark] def addPendingTask(index: Int) {
+ private[spark] def addPendingTask(
+ index: Int,
+ initializing: Boolean = false,
Review comment:
I'm not sure I like passing these arguments to this function. Could this be
solved with a `resolveRacks: Boolean` argument, and using `pendingTasksForHost`
to resolve the racks in the `addPendingTasks` method?
It seems that `initializingMap` and `pendingTasksForHost` are pretty much
the same thing during initialization.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
