maropu commented on a change in pull request #24118: [SPARK-26736][SQL] if
filter condition `And` has non-determined sub function it does not do partition
prunning
URL: https://github.com/apache/spark/pull/24118#discussion_r268375974
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
##########
@@ -63,10 +63,16 @@ object PhysicalOperation extends PredicateHelper {
val substitutedFields =
fields.map(substitute(aliases)).asInstanceOf[Seq[NamedExpression]]
(Some(substitutedFields), filters, other,
collectAliases(substitutedFields))
- case Filter(condition, child) if condition.deterministic =>
- val (fields, filters, other, aliases) =
collectProjectsAndFilters(child)
- val substitutedCondition = substitute(aliases)(condition)
- (fields, filters ++ splitConjunctivePredicates(substitutedCondition),
other, aliases)
+ case filter @ Filter(condition, child)
+ if condition.deterministic || condition.isInstanceOf[And] =>
+ val determinedCondition = getDeterminedExpression(condition)
+ if (determinedCondition.isDefined) {
+ val (fields, filters, other, aliases) =
collectProjectsAndFilters(child)
+ val substitutedCondition =
substitute(aliases)(determinedCondition.get)
+ (fields, filters ++
splitConjunctivePredicates(substitutedCondition), other, aliases)
+ } else {
+ (None, Nil, filter, Map.empty)
+ }
Review comment:
Yea, but they are end-to-end tests, so I think we need more fine-grained
tests for `collectProjectsAndFilters`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
