dongjoon-hyun commented on a change in pull request #24158: [SPARK-26847][SQL]
Pruning nested serializers from object serializers: MapType support
URL: https://github.com/apache/spark/pull/24158#discussion_r268413498
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/objects.scala
##########
@@ -121,9 +121,7 @@ object EliminateMapObjects extends Rule[LogicalPlan] {
object ObjectSerializerPruning extends Rule[LogicalPlan] {
/**
- * Collects all struct types from given data type object, recursively.
Supports struct and array
- * types for now.
- * TODO(SPARK-26847): support map type.
+ * Collects all struct types from given data type object, recursively.
*/
def collectStructType(dt: DataType, structs: ArrayBuffer[StructType]):
ArrayBuffer[StructType] = {
Review comment:
+1 for @maropu 's suggestion. It's helpful. For Scala, Apache Spark commonly
uses `Visible for testing` in the function description comment. You can search
`Visible for testing` from the code base.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
