srowen commented on a change in pull request #24187: [SPARK-27256][CORE][SQL]If
the configuration is used to set the number of bytes, we'd better use
`bytesConf`'.
URL: https://github.com/apache/spark/pull/24187#discussion_r268466247
##########
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##########
@@ -579,15 +579,15 @@ package object config {
private[spark] val FILES_MAX_PARTITION_BYTES =
ConfigBuilder("spark.files.maxPartitionBytes")
.doc("The maximum number of bytes to pack into a single partition when
reading files.")
- .longConf
+ .bytesConf(ByteUnit.BYTE)
Review comment:
I'm not sure this is a net helpful change, as the parameter is
maxPartition*Bytes*. I agree it would have been better to call it
`maxPartitionSize` and accept values like "10m". I'm not strongly against it,
as existing values would still work.
For other property values without "Bytes", I agree.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
